Skip to content

[JExtract] Introduce SwiftKnownTypes #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

[JExtract] Introduce SwiftKnownTypes #271

merged 1 commit into from
Jun 15, 2025

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Jun 13, 2025

to construct stdlib types easily.

For example, constructing UnsafePointer<Int8> is now:

knownTypes.unsafePointer(knownTypes.int8)

compared to:

SwiftType.nominal(SwiftNominalType(
  nominalTypeDecl: swiftStdlibTypes.unsafePointerDecl,
  genericArguments: [
    .nominal(SwiftNominalType(nominalTypeDecl: swiftStdlibTypes[.int8]))
  ]
))

Rename SwiftStandardLibraryTypes to SwiftStandardLibraryTypeDecls
Rename KnownStandardLibraryType to SwiftStandardLibraryTypeKind

@rintaro
[JExtract] Introduce SwiftKnownTypes
673689e 
to construct stdlib types easily.
Rename `SwiftStandardLibraryTypes` to `SwiftStandardLibraryTypeDecls`
Rename `KnownStandardLibraryType` to `SwiftStandardLibraryTypeKind`
ktoso
ktoso approved these changes Jun 15, 2025
View reviewed changes
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Very good to Swift... prefix them as well, thank you!

@ktoso ktoso merged commit 97770cf into swiftlang:main Jun 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktoso ktoso ktoso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rintaro @ktoso